-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MIDI over BLE support for ESP32, ArduinoBLE and Raspberry Pi Pico W #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of changes completely refactors the high-level
BluetoothMIDI_Interace
implementation to have it support many different backends using different BLE libraries. Previously, only the Bluedroid stack on ESP32 was supported.The following backends are now supported:
To make use of MIDI over BLE, add
#include <MIDI_Interfaces/BluetoothMIDI_Interface.hpp>
to your sketch.The
BluetoothMIDI_Interface
API remains mostly the same, except for theflush()
function, which has been removed in favor ofsendNow()
, for consistency with the other MIDI interfaces. The originalBluetoothMIDI_Interface
tests have been ported, and new tests for some of the low-level BLE packet buffering functions have been added.The documentation now includes a MIDI over BLE page with details about the different backends.
An example named BLEMIDI-Adapter.ino has been added.